Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Management: Documentation #23430

Merged
merged 7 commits into from
Mar 16, 2022

Conversation

donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Feb 4, 2022

Documentation accompanying #23392. Explains concepts required for three.js users to understand color management, including:

  • What is a color space?
    • ... and differences between sRGB and Linear-sRGB
  • Roles of color spaces
    • ... and how to know which to use in different contexts
  • Working with THREE.Color instances

Live Preview: three.js / docs / getting started / color management

/cc @gkjohnson @WestLangley @Mugen87


Aside: I'm very grateful to @WestLangley for explaining foundational color science concepts to me, and to @sobotka for correcting my (many) misconceptions in this process. Any mistakes in this PR are of course mine, and I hope the new documentation can pay their help forward to the three.js community somewhat. ☺️

@donmccurdy donmccurdy force-pushed the feat-color-management-v4-pt2 branch from 283bea3 to 3af2981 Compare March 10, 2022 05:08
Repository owner deleted a comment from nyan-left Mar 11, 2022
@WestLangley
Copy link
Collaborator

oops. reconstructing the essence of a side discussion between @nyan-left and @WestLangley...

@WestLangley said:

This comment provides the reason why fog and clear-color are currently a special case.

@donmccurdy donmccurdy marked this pull request as ready for review March 13, 2022 00:56
@donmccurdy
Copy link
Collaborator Author

This PR is ready for review — given the changes coming in #23392, publishing the these docs with r139 might be ideal.

@WestLangley — no pressure, but I'm happy to make any changes you'd recommend here!

@mrdoob mrdoob merged commit fe2bd0d into mrdoob:dev Mar 16, 2022
@mrdoob
Copy link
Owner

mrdoob commented Mar 16, 2022

Thanks!

@donmccurdy donmccurdy deleted the feat-color-management-v4-pt2 branch March 16, 2022 18:20
@WestLangley
Copy link
Collaborator

@donmccurdy Better late than never... I just want to say thank you for all your work on this. :-)

abernier pushed a commit to abernier/three.js that referenced this pull request Sep 16, 2022
* Color Management: Documentation

* Color Management: Clean up documentation

* Documentation: Add color space constants.

* Color management: Documentation revisions.

* Color Management: Remove unused illustration.

* Color Management: Revisions to documentation.

* Color Management: Documentation should use title case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants