Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeEditor: minor improvement #23425

Merged
merged 3 commits into from
Feb 6, 2022
Merged

NodeEditor: minor improvement #23425

merged 3 commits into from
Feb 6, 2022

Conversation

fyoudine
Copy link
Contributor

@fyoudine fyoudine commented Feb 4, 2022

Adding some minor improvement and fix

@fyoudine
optimize joinNode
63f82b7
@fyoudine
NODE EDITOR: FIX InvertEditor nodeClass
ac1f60d
@fyoudine
NODE EDITOR:
c15bb50 
Add NumberInputs to PowerEditor / OperatorEditor / LimiterEditor
Move NULL_VALUE inside class to avoid sharing value against multiple instances
Add Saturate in LimiterEditor
@mrdoob mrdoob requested a review from sunag February 4, 2022 16:42
@mrdoob mrdoob added this to the r138 milestone Feb 4, 2022
@sunag
Copy link
Collaborator

sunag commented Feb 5, 2022

About JoinNode you are adding support for multi-vector inputs, right? e.g: [ vec2, float ] -> vec3?

@fyoudine
Copy link
Contributor Author

fyoudine commented Feb 5, 2022

About JoinNode you are adding support for multi-vector inputs, right? e.g: [ vec2, float ] -> vec3?

Hello @sunag exactly

sunag
sunag approved these changes Feb 6, 2022
View reviewed changes
Copy link
Collaborator

@sunag sunag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! I think we need to rename JoinEditor names later to be more compliant. ( Maybe rename it in runtime from node input )

image

@sunag sunag merged commit c6185aa into mrdoob:dev Feb 6, 2022
@sunag
Copy link
Collaborator

sunag commented Feb 6, 2022

Thanks!

donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
@fyoudine @donmccurdy
NodeEditor: minor improvement (mrdoob#23425)
f57cf7e 
* optimize joinNode: Support for multi-vector inputs, right? e.g: [ vec2, float ] -> vec3?

* NODE EDITOR: FIX InvertEditor nodeClass

* NODE EDITOR:
Add NumberInputs to PowerEditor / OperatorEditor / LimiterEditor
Move NULL_VALUE inside class to avoid sharing value against multiple instances
Add Saturate in LimiterEditor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunag sunag sunag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r138
Development

Successfully merging this pull request may close these issues.
3 participants
@fyoudine @sunag @mrdoob