-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLTFLoader: Allow textures which share the image source #23420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirox
changed the title
GLTFLoader: Allow shared image source textures
GLTFLoader: Allow textures which share the image source
Feb 3, 2022
Note: Two e2e tests fail
But they don't use |
Mugen87
reviewed
Feb 3, 2022
takahirox
force-pushed
the
GLTFLoaderShareImageSource
branch
from
February 3, 2022 12:32
e4ced3b
to
e4baec9
Compare
takahirox
force-pushed
the
GLTFLoaderShareImageSource
branch
from
February 3, 2022 12:45
e4baec9
to
7aacf50
Compare
donmccurdy
approved these changes
Feb 3, 2022
Thanks! |
Added a note about the breaking change to the migration guide https://github.com/mrdoob/three.js/wiki/Migration-Guide Please feel free to rephrase what I wrote because English isn't my first language. |
0b5vr
added a commit
to 0b5vr/three-ts-types
that referenced
this pull request
Mar 1, 2022
Merged
3 tasks
joshuaellis
pushed a commit
to three-types/three-ts-types
that referenced
this pull request
Mar 1, 2022
* change (GLTFLoader): add a new signature GLTFParser.loadImageSource See: mrdoob/three.js#23420 * docs: remove an obsolete comment
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
* GLTFLoader: Allow shared image source textures * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows
GLTFLoader
to create textures which share the same image source if multiple textures point to the same texture image source in glTF def.Benefits:
Changes:
parser.loadTextureImage()
from texture source def object to source index. It can break external glTF loader plugins. Source index is needed for caching described below.loadImageSource(sourceIndex, loader)
to parser which caches textures with source index. If cache misses, it creates a new texture from a source def. If cache hits, it clones the cached texture (so that source is shared).Side note:
/cc @donmccurdy