Update GLTFLoader doc for texture transform extension #23417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Source has been introduced, texture transform extension no longer needs duplicate texture upload to GPU.
|
We should check that this works as expected, but yes it sounds like this has been fixed! 🎉 |
|
I think we are not there yet. We have to get rid of this code next: |
|
Yes, for perfect texture transform extension support we need to allow uv transform per texture in a material. But, thanks to Source, at least the following sentence is out dated and I think it can be remove from the doc. |
Mugen87
approved these changes
Feb 4, 2022
|
Thanks! |
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
As Source has been introduced, texture transform extension no longer needs duplicate texture upload to GPU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If I'm right, as Source has been introduced #17766, GLTFLoader texture transform extension no longer needs duplicate texture upload to GPU.
/cc @donmccurdy