Core: Enable blending when Material.blending is not set to NormalBlending #23416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
reviewed
Feb 2, 2022
gkjohnson
changed the title
|
Thanks! |
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
…ding (mrdoob#23416) * don't render as opaque if CustomBlending is enabled * Add CustomBlending import * add forgetten line * Update "opaque" condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23408
Description
This adjusts the WebGLProgram do only prepend the
#define OPAQUEflag if transparent is true and blending is not set to CustomBlending. This retains the current behavior or forcing alpha to write as "1" by default when rending non transparent flagged objects but allows the user to force blending with the "CustomBlending" flag.Tested by creating a cube with CustomBlending and transparent = false with partial opacity: