Removed VRMLoader #23414
Merged
Removed VRMLoader #23414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makc
reviewed
Feb 3, 2022
| @@ -120,7 +120,6 @@ | |||
| "webgl_loader_texture_tga", | |||
| "webgl_loader_ttf", | |||
| "webgl_loader_vox", | |||
| "webgl_loader_vrm", | |||
| "webgl_loader_vrml", | |||
There was a problem hiding this comment.
you removed webgl_loader_vrm with the anime girl but not webgl_loader_vrml with the building
There was a problem hiding this comment.
wait, are these actually two different loaders 🤦
There was a problem hiding this comment.
VRMLoader
VRMLLoaderSpot the difference 😁
0b5vr
added a commit
to 0b5vr/three-ts-types
that referenced
this pull request
Feb 22, 2022
0b5vr
added a commit
to 0b5vr/three-ts-types
that referenced
this pull request
Feb 22, 2022
This was referenced Feb 22, 2022
joshuaellis
pushed a commit
to three-types/three-ts-types
that referenced
this pull request
Mar 1, 2022
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
People should use https://github.com/pixiv/three-vrm instead.
/fyi @0b5vr