Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Remove deprecated WGSL syntax. #23393

Merged
merged 3 commits into from
Jan 31, 2022
Merged

WebGPURenderer: Remove deprecated WGSL syntax. #23393

merged 3 commits into from
Jan 31, 2022

Conversation

webglzhang
Copy link
Contributor

Description

Use deprecated language feature: [[decoration]] style decorations have been replaced with @decoration style.

The document in wgsl like this

@group(0) @binding(0)
var<storage,read> buf1: Buffer;       // Can read, cannot write.

Copy link
Collaborator

@takahirox takahirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR!

@Mugen87 Mugen87 added this to the r138 milestone Jan 31, 2022
@Mugen87 Mugen87 changed the title Use deprecated language feature in WGSL WebGPURenderer: Remove deprecated WGSL syntax. Jan 31, 2022
@Mugen87 Mugen87 merged commit 729d327 into mrdoob:dev Jan 31, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 31, 2022

Thanks!

donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
* fix matrix.lookAt parameter document

* Use [[decoration]] style decorations  replaced to @decoration style

Co-authored-by: webglzhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants