OBJExporter: Convert Linear vertex colors to sRGB #23374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23283
Description
Convert colors to sRGB before OBJ Export. It looks like OBJExporter was only including colors for points instead of triangles.
https://raw.githack.com/gkjohnson/three.js/obj-export-color/examples/misc_exporter_obj.html
Note that because colors are converted now it's possible that the final color value is formed from a long decimal value:
Is there a quick way to truncate that to 4 or 5 decimal places? I only know of
parseFloat( color.r.toFixed( 4 ) )
which works but seems a bit roundabout. Or do we need to do that? It looks like the positions are not truncated in any way.