Manual: Refactor Import Maps support in live editor. #23373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, there's also #23371 🧐 |
This is a more generic fix than hardcoding checks for 'three'. Also fixes the export function.
greggman
force-pushed
the
fix-live-editor-for-r137
branch
from
347ddd9 to
7b3f5bc
Compare
|
I would start with this PR. #23371 contains too many changes at once. |
Mugen87
changed the title
|
Thanks! |
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
This is a more generic fix than hardcoding checks for 'three'. Also fixes the export function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more generic fix than hard coding checks for 'three'.
Also fixes the export function.
Related issue: #23363
Description
The live editor didn't handle import maps. Now it kinda maybe does