Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLUtils: Add fallback for RGBFormat. #23367

Closed
wants to merge 2 commits into from
Closed

WebGLUtils: Add fallback for RGBFormat. #23367

wants to merge 2 commits into from

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 28, 2022

Related issue: #23366

Description

Second attempt for implementing a warning and RGBA fallback when RGBFormat is used.

@mrdoob
Copy link
Owner

mrdoob commented Jan 28, 2022

@Mugen87 Should I cherry-pick this into master and release 0.137.5?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jan 28, 2022

That would be great! 👍

@mrdoob mrdoob added this to the r137 milestone Jan 28, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 28, 2022

Cherry-picked in master.

@mrdoob mrdoob closed this Jan 28, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 28, 2022

Thanks!

@divisuals divisuals mentioned this pull request Mar 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WestLangley WestLangley WestLangley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r137
Development

Successfully merging this pull request may close these issues.
3 participants
@Mugen87 @mrdoob @WestLangley