Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #23353
Description
(Hoping to merge this ASAP and publish
0.137.3
)After #23230 we now have a regression when someone does this: https://jsfiddle.net/7rt8L1jo/
The best way that I can think of to fix that is to set
gl_FragColor = 1.0
in the shader whentransparent === false
, which is pretty much what I tried to do in #18631 two years ago.As far as I can read, the only use case that that change broke was this:
Which I think is totally fair to break in exchange of solving this regression.
To me
material.transparent = false
means that the object is opaque so forcing alpha to 1.0 makes sense.After this change
material.alphaWrite
(introduced in #23166) is no longer needed./cc @Mugen87 @donmccurdy @WestLangley