PLYLoader: convert vertex colors to linear #23342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
|
How does this DeepScan plugin work that it marks new problems in files unrelated to the PR? |
Yeah. Still trying to figure how it works. You can ignore it... |
|
Thanks! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23283
Description
Convert the loaded vertex colors from PLY from srgb to linear.
Tested using the "dolphins_colored.ply" file in the repo. All the vertex colors seem to be fully 0 or 1 in that file so changes in brightness are not so apparent but you can see the differences in the transition between colors on the rainbow dolphin.