Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for Layers to CSS3DObject/CSS2DRenderer #23316

Merged
merged 5 commits into from
Jan 25, 2022
Merged

add support for Layers to CSS3DObject/CSS2DRenderer #23316

merged 5 commits into from
Jan 25, 2022

Conversation

thisGH
Copy link
Contributor

@thisGH thisGH commented Jan 24, 2022 •
edited
Loading

Description

  • add support for Layers to CSS3DObject
  • calculate CSSMatrix only when object is visible

@mrdoob
Copy link
Owner

mrdoob commented Jan 24, 2022

Nice!

Could you add this to CSS2DObject too?

@mrdoob mrdoob added this to the r137 milestone Jan 24, 2022
@thisGH thisGH changed the title add support for Layers to CSS3DObject add support for Layers to CSS3DObject/CSS2DRenderer Jan 25, 2022
@thisGH
Copy link
Contributor Author

thisGH commented Jan 25, 2022

Nice!

Could you add this to CSS2DObject too?

Sure, it's done

@thisGH thisGH closed this Jan 25, 2022
@thisGH thisGH reopened this Jan 25, 2022
@mrdoob mrdoob merged commit 2202d9c into mrdoob:dev Jan 25, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 25, 2022

Thanks!

@bergden-resonai bergden-resonai mentioned this pull request Jan 27, 2022
Merged
@vasturiano vasturiano mentioned this pull request Feb 4, 2022
Open
@Mugen87 Mugen87 mentioned this pull request Feb 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r137
Development

Successfully merging this pull request may close these issues.
3 participants
@thisGH @mrdoob @Mugen87