NodeEditor: Add missing position entries #23310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing normal entry according to NormalNode Add missing Angle/Trigonometry functions
Closed
sunag
reviewed
Jan 24, 2022
| @@ -13,7 +13,8 @@ export class NormalEditor extends BaseNode { | |||
| const optionsField = new SelectInput( [ | |||
| { name: 'Local', value: NormalNode.LOCAL }, | |||
| { name: 'World', value: NormalNode.WORLD }, | |||
| { name: 'View', value: NormalNode.VIEW } | |||
| { name: 'View', value: NormalNode.VIEW }, | |||
| { name: 'Geometry', value: NormalNode.GEOMETRY }, | |||
There was a problem hiding this comment.
I think that we can remove it , and others at the end of the array.
sunag
reviewed
Jan 24, 2022
| @@ -10,12 +10,19 @@ export class TrigonometryEditor extends BaseNode { | |||
|
|
|||
| const node = new MathNode( MathNode.SIN, DEFAULT_VALUE ); | |||
|
|
|||
| super( 'Trigonometry', 1, node, 175 ); | |||
| super( 'Angle / Trigonometry', 1, node, 220 ); | |||
There was a problem hiding this comment.
I wish I had separated Angle from Trigonometry in Editor. @mrdoob Some suggestion?
There was a problem hiding this comment.
Do you mean having a node that mostly converts radians to degrees?
There was a problem hiding this comment.
Yes, yes. A Node in Editor only for it.
sunag
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing position entry according to PositionNode
Add missing normal entry according to NormalNode
Add missing Angle/Trigonometry functions