Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeEditor: Fixes #23309

Merged
merged 2 commits into from
Jan 25, 2022
Merged

NodeEditor: Fixes #23309

merged 2 commits into from
Jan 25, 2022

Conversation

fyoudine
Copy link
Contributor

FIX NodeEditor

  • use the right Editor Class for Normalize entry
  • traverser error if no scene set
    FIX MeshEditor
  • fix import for three

@fyoudine
FIX NodeEditor
09f0de1 
- use the right Editor Class for Normalize entry
- traverser error if no scene set
FIX MeshEditor
- fix import for three
@fyoudine fyoudine mentioned this pull request Jan 24, 2022
Closed
@sunag
Copy link
Collaborator

sunag commented Jan 24, 2022

Is necessary just add MrDoob Code Style, for example:

if ( object3d !== null ) {

@sunag sunag changed the title FIX NodeEditor NodeEditor: Fixes Jan 24, 2022
@mrdoob mrdoob added this to the r137 milestone Jan 24, 2022
@mrdoob mrdoob requested a review from sunag January 25, 2022 19:50
@sunag sunag merged commit be80adf into mrdoob:dev Jan 25, 2022
@sunag
Copy link
Collaborator

sunag commented Jan 25, 2022

Thanks!

@sunag sunag mentioned this pull request Jan 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunag sunag Awaiting requested review from sunag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r137
Development

Successfully merging this pull request may close these issues.
3 participants
@fyoudine @sunag @mrdoob