-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve vr haptics example #23307
Improve vr haptics example #23307
Conversation
- make audio more pleasant a) changing frequency to a pentatonic b) changing oscillator from square to sine type - fix a bug so multiple boxes can simultaneously light up when more than 1 controllers is used
ahhh silly me, that's an off-by-one error - i had one less note in the music scale than the number of boxes. |
I think one note is repeated but it's definitely better than before. |
Thanks! |
Further improvement ideas: We should just just use https://tonejs.github.io/ here. It'll sound much better 🤓 |
Right, I shouldn't have include 12 (which is basically the same note as 0). 😅
I was just looking at that too... looks tone.js can do a lot if we are ok with pulling an extra dependency |
😁
Yeah, that's not a problem. We should definitely up our game sound-wise. |
Description
a) changing frequency to a pentatonic
b) changing oscillator from square to sine type
more than 1 controllers is used
before
after
https://raw.githack.com/zz85/three.js/improve_haptics/examples/webxr_vr_haptics.html