SVGLoader: fix use.href in non-browser environments #23297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yomboprime
approved these changes
Jan 22, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code processing
<use>tag tries to accesshrefattribute using DOM element property ignoring the fact it is namespaced (conventionally withxlinkalias).It works in major browsers but fails in some environments that follow the W3C standard. Notably, jsdom. This patch makes it possible to use SVGLoader in NodeJS, and still keeps the original behavior in browsers. Also, it makes the code a little more consistent with surroundings that explicitly use
getAttributemethod rather than propetry-based access.