Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferGeometry: Faster setIndex from Array #23290

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Conversation

neofuji
Copy link
Contributor

@neofuji neofuji commented Jan 21, 2022

Related issue: #10603

Description

BufferGeometry.prototype.setIndex calculates the max value of the Array with iterating all items.
It would be enough to find just one item over 65535, and the max value is not necessary.

src/utils.js Outdated Show resolved Hide resolved
@mrdoob mrdoob added this to the r137 milestone Jan 21, 2022
@mrdoob mrdoob merged commit 84f3e57 into mrdoob:dev Jan 21, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 21, 2022

Thanks!

@joshuaellis joshuaellis mentioned this pull request Jan 27, 2022
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants