Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Add temporary sRGB encoding fix for WebXR. #23288

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 20, 2022

Fixed #23278.

Description

see #23278 (comment).

@arpu Do you mind verifying if this works for you?

@cabanier
Copy link
Contributor

This looks good! I hope it fixes the problem.

@Mugen87 Mugen87 added this to the r137 milestone Jan 20, 2022
@Mugen87 Mugen87 merged commit b83bab0 into mrdoob:dev Jan 20, 2022
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jan 20, 2022

Merging for further testing.

New build files: 63ffa26

@arpu
Copy link

arpu commented Jan 20, 2022

tested this, same result darker Textures but using

_currentRenderTarget.texture.encoding

fixed it

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jan 20, 2022

Of course 🤦 ! I make a new PR.

@mrdoob
Copy link
Owner

mrdoob commented Jan 20, 2022

Thanks!

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jan 20, 2022

New builds 6365075.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

darker textures in WebxrSession in latest dev git
4 participants