Fix utils: getTypedArray unit test. #23258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer is Node.js specific and the unit test fails on browsers. Better to replace it with ArrayBuffer which is available on both Node.js and browsers.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #23257
Description
getTypedArray()unit test fails on browsers withReferenceError: Buffer is not definederror while the test passes on Node.js.I think
Bufferis Node.js specific. Better to replace it withArrayBufferwhich is available on both Node.js and browsers.Basically the test just does
new TypedArray( buffer )and check the instance type. I don't think replacing withArrayBufferis problematic.Refer to #23257 for the problem.