Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Only use sRGB shader encode for default framebuffer. #23253

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 17, 2022

Related issue: Fixed #23251.

Description

The inline shader sRGB encode only needs to be done for the default framebuffer.

@Mugen87 Mugen87 added this to the r137 milestone Jan 17, 2022
@Mugen87 Mugen87 merged commit 63f7beb into mrdoob:dev Jan 17, 2022
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jan 17, 2022

Updated builds for further testing: e2dac11

@mrdoob
Copy link
Owner

mrdoob commented Jan 18, 2022

Thanks!

chubei-oppen added a commit to chubei-oppen/three.js that referenced this pull request Mar 17, 2022
chubei-oppen added a commit to oppenfuture/three.js that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outputEncoding not handled correctly when using sRGB render target in WebGL2
3 participants