-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDrawLoader cleanup and docs improvement #23231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Great to have documentation for the loader. One note is that I am working on a relatively large PR for LDrawLoader to convert the logic to cache the geometry so I'd like to avoid conflicts if you're planning to make other changes. I'll try to retain the modifications you've made here in the upcoming PR, though.
I'm sorry for the conflicts. I'm not planning to do more PRs to the loader for now. |
Thanks! |
Related PR: #23173
Description
This PR is just cleanup of some LDrawLoader small details I saw while creating the documentation.
Also added some improvements to the loader docs.