Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Remove remaining RGBFormat usage. #23218

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 13, 2022

Related issue: #XXXX

Description

This PR removes the remaining usage of RGBFormat.

  • GLTFExporter only supports RGBA8 now.
  • Lensflare can only be used when the alpha context parameter of WebGLRenderer is set to true. That is because Lensflare uses an instance of FramebufferTexture with RGBAFormat so the drawing buffer requires alpha, too.

@mrdoob mrdoob added this to the r137 milestone Jan 13, 2022
@mrdoob mrdoob merged commit 8ca01f8 into mrdoob:dev Jan 13, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 13, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants