Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loaders: Stop usage of RGBFormat. #23201

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Loaders: Stop usage of RGBFormat. #23201

merged 1 commit into from
Jan 11, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 11, 2022

Related issue: -

Description

We can't use RGBELoader with WebGPURenderer right now since the loader returns RGB textures. 3 channel formats are not supported with WebGPU. And also in context of WebGL it's recommended to always use RBGA since RGB might be emulated (e.g. with a Metal backend).

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jan 11, 2022

@gkjohnson I did not touch LUT3dlLoader since there is no example for testing and I did not fully understand the index and scale logic in parse(). Can you take care of it?

@gkjohnson
Copy link
Collaborator

I've create #23202 which adds a 3DL example file. I'll take a look at removing the RGBFormat use over the next few days.

@mrdoob mrdoob added this to the r137 milestone Jan 11, 2022
@mrdoob mrdoob merged commit b9a7cbf into mrdoob:dev Jan 11, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 11, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants