Fix DOMException when trying to use XR inside an iframe #23174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ALLOWED" / "AR NOT ALLOWED" instead and align VR/AR code
hybridherbst
force-pushed
the
fix-xr-dom-exception
branch
from
de19a4c to
4f6510f
Compare
|
I'd like to make a follow-up PR to clean up ARButton and VRButton more / fix issues with some devices but it would be great if this here is merged first - or some feedback :) |
Mugen87
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
According to the spec calling isSessionSupported() can potentially reject the promise and then execute the rejection handler with a DOMException instead.
It seems the only cause for this exception is the mentioned security error:
If the requesting document’s origin is not allowed to use the "xr-spatial-tracking" permissions policy, reject promise with a "SecurityError" DOMException and return it.
Regarding this definition, the PR is definitely an improvement.
|
Thanks! |
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
… ALLOWED" / "AR NOT ALLOWED" instead and align VR/AR code (mrdoob#23174)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a DOMException that can happen when someone tried to use the VR/AR buttons inside an iFrame, which needs a special iFrame permission
xr-spatial-tracking. Instead of throwing, the exception is now logged as warning to the console as well.ARButton already had that, so this PR adds it to VRButton and amends the messaging for both somewhat (now saying "NOT ALLOWED" instead of "NOT SUPPORTED").
To see the current state with DOMException go to this page and look at the console before Glitch fixes iframe permissions on their end: https://glitch.com/~three-xr
This contribution is funded by 🌵 Needle.