Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23157 (comment)
Description
Convert all variable names and comments with the spelling "colour" to "color" in LDrawLoader.
Also it occurs to me that merging all geometry within a single loaded LDraw hierarchy using
BufferGeometryUtils.mergeBufferGeometries
is not so straight forward. In order to get an optimal model you need to make sure all faces that share a material are sorted next to each other and grouped. And some of the LDraw meshes will have multiple materials. It would need to be a mesh and material-aware geometry merge which is more complicated than I initially anticiptated so we'll have to revisit that another time.https://raw.githack.com/gkjohnson/three.js/ldraw-colour-color/examples/webgl_loader_ldraw.html