-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: Use import maps polyfill #23163
Conversation
Hmm... In case of revert we should be add this polyfill to |
@sunag Could you take care of that? |
Should we have something like {
"imports": {
"three": "../build/three.module.js",
"three-nodes": "../jsm/renderers/nodes/Nodes.js"
}
} |
Hmm, right now |
@mrdoob I think in something like this: |
Yesterday I registered the package just in case 😀 |
@marcofugaro Is there a way of publishing multiple packages from the same package.json/repo? We may need to move |
Not with plain npm, but there are some tools/scripts. @mrdoob what do you think about this aliasing instead? This way we don't have to publish a new package. import { ArrayInputNode } from 'three/nodes' |
Hi, the import maps polyfill/shim is preventing Safari from being able to run app code if dev tools are open, so there would be no way to use dev tools to work on safari-specific issues with three.js apps. Are we aware of the issue? I'll also follow up at https://github.com/guybedford/es-module-shims. |
@unphased no issues for me in safari devtools, are you sure this isn't caused by some other part of your application? |
If you reload while the dev tools window is open, does the 3d scene load at all for you? |
Yup, all normal. |
Thanks for confirming. So, you still get the error |
Ok so I wasn't accounting for the slower execution speed when devtools are open. the Threejs examples do work as you say, sorry about that. |
Related issue: #23148