Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDrawLoader: remove separateobjects flag #23147

Merged
merged 5 commits into from
Jan 4, 2022

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #23139 (comment)

Description

  • Removes the LDrawLoader.separateObjectst flag from both the class and the example -- this can be added back at a future time if needed.
  • This PR also moved the inversion of primitive winding order if the transformation matrix is scale inverted out of objectParse, as well.
  • Moves the parseVector function to LineParser.getVector.

Next up will be rethinking the "main" color used when loading a sub file so the parsed contents of individual files can be more easily cached.

@gkjohnson gkjohnson requested a review from yomboprime January 4, 2022 20:41
@mrdoob mrdoob added this to the r137 milestone Jan 4, 2022
@mrdoob mrdoob merged commit 687e14f into mrdoob:dev Jan 4, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 4, 2022

Thanks!

@gkjohnson gkjohnson deleted the ldraw-remove-separateobjects branch January 5, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants