Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDrawLoader: Throw Errors instead of strings #23135

Merged
merged 2 commits into from
Jan 3, 2022
Merged

LDrawLoader: Throw Errors instead of strings #23135

merged 2 commits into from
Jan 3, 2022

Conversation

gkjohnson
Copy link
Collaborator

Related issue: --

Description

Throw proper Javascript Errors rather than strings in LDrawLoader.

@gero3 gero3 mentioned this pull request Jan 3, 2022
Merged
@mrdoob mrdoob added this to the r137 milestone Jan 3, 2022
@mrdoob mrdoob merged commit 6010f81 into mrdoob:dev Jan 3, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 3, 2022

Thanks!

@gkjohnson gkjohnson deleted the ldraw-throw-errors branch January 3, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryihan ryihan ryihan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r137
Development

Successfully merging this pull request may close these issues.
3 participants
@gkjohnson @mrdoob @ryihan