Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed uniform sheenRoughness #23119

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Fixed uniform sheenRoughness #23119

merged 2 commits into from
Dec 30, 2021

Conversation

ycw
Copy link
Contributor

@ycw ycw commented Dec 30, 2021

Description

sheenRoughness defaults to 1.0

@@ -299,7 +299,7 @@ ShaderLib.physical = {
sheen: { value: 0 },
sheenColor: { value: new Color( 0x000000 ) },
sheenColorMap: { value: null },
sheenRoughness: { value: 0 },
sheenRoughness: { value: 1 },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exact values do actually not matter. It's only the type which is important so that something like uniform.value.copy() works.

Anyway, for consistency it's probably better to apply the actual default values. You can also update specularIntensity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct. i'm extending the MeshPhysicalMaterial to achieve light rim...

@Mugen87 Mugen87 added this to the r137 milestone Dec 30, 2021
@mrdoob mrdoob merged commit 44837d1 into mrdoob:dev Dec 30, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 30, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants