WebGLMorphtargets: Dispose morph textures when corresponding geometry is disposed. #23104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original discussion: https://discourse.threejs.org/t/how-do-i-free-morph-textures/33033
Description
Morph textures are not disposed when disposing corresponding geometries.
In WebGLMorphtargets, since each morph textures are one-to-one to each geometries and it only referred from this part,
it can be safely disposed once geometry is disposed.
I have added an event listener of
'dispose'
to geometry that disposes the morph texture.This will ensure morph textures be freed once it's no longer necessary.