Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationMixer: Fix wrong reference count in _bindAction(). #23102

Merged
merged 2 commits into from
Dec 29, 2021

Conversation

walton007
Copy link
Contributor

@walton007 walton007 commented Dec 28, 2021

Related issue: Fixed #23096

Description

When calling the uncacheAction, uncacheClip, and uncacheRoot methods, an exception will be thrown.

@mrdoob
Copy link
Owner

mrdoob commented Dec 28, 2021

Seems like you reformatted the whole file by mistake:
https://github.com/mrdoob/three.js/pull/23102/files

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 28, 2021

I've fixed the style issues. PR should be okay now.

@Mugen87 Mugen87 changed the title fix: miss binding.referenceCount++ error when AnimationMixer._bindAct… AnimationMixer: Fix wrong reference count in _bindAction(). Dec 28, 2021
@Mugen87 Mugen87 added this to the r137 milestone Dec 28, 2021
@mrdoob mrdoob merged commit d088fd2 into mrdoob:dev Dec 29, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 29, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

miss binding.referenceCount++ error when AnimationMixer._bindAction
3 participants