LDrawLoader Example: Demonstrate loading flat colors to match instruction booklet style #23098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: --
Description
Adds a "Flat Colors" option to the LDrawLoader example to better match the rendering style used in official lego instruction manuals.
Live demo:
https://raw.githack.com/gkjohnson/three.js/ldraw-flat-colors/examples/webgl_loader_ldraw.html
Comparing to the instruction manuals again it definitely looks like the instruction manual rendering is a bit more stylized with subtle lighting and uses an orthographic camera but I think the flat materials suit the instruction book look more closely. It seems this is also how at least one of the LDraw editor tools, LeoCAD, renders the models.
cc @yomboprime