Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Refactor URL generation in geometry browser. #23087

Merged
merged 2 commits into from
Dec 28, 2021
Merged

Docs: Refactor URL generation in geometry browser. #23087

merged 2 commits into from
Dec 28, 2021

Conversation

gero3
Copy link
Contributor

@gero3 gero3 commented Dec 25, 2021

Description
This fixes the following lgtm error =>
LGTM Error

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 26, 2021

No new or fixed alerts

I wonder why lgtm does not recognize this change as a fix for an alert 🤔 .

@gero3
Copy link
Contributor Author

gero3 commented Dec 26, 2021

This is becuase the file gets classified as docs. A classification removes the alerts from the total that gets shown.
image

The alert still gets shown when you show excluded files.
=> LGTM

#23062 removes the classification from the docs folder.

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 27, 2021

Thanks for the clarification. I've just updated the code a bit so it looks similar to what's happen in chooseFromHash().

@Mugen87 Mugen87 added this to the r137 milestone Dec 27, 2021
@Mugen87 Mugen87 changed the title Limit LGTM errors Docs: Refactor URL generation in geometry browser. Dec 27, 2021
@mrdoob mrdoob merged commit 5169da8 into mrdoob:dev Dec 28, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 28, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r137
Development

Successfully merging this pull request may close these issues.
3 participants
@gero3 @Mugen87 @mrdoob