Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color: Remove gamma-related methods #23082

Merged
merged 2 commits into from
Dec 24, 2021
Merged

Color: Remove gamma-related methods #23082

merged 2 commits into from
Dec 24, 2021

Conversation

donmccurdy
Copy link
Collaborator

@donmccurdy donmccurdy commented Dec 24, 2021 •
edited
Loading

  • Removed: copyGammaToLinear, copyLinearToGamma, convertGammaToLinear, convertLinearToGamma.
  • Recommended: copySRGBToLinear, copyLinearToSRGB, convertSRGBToLinear, convertLinearToSRGB.

See: #23080

@donmccurdy donmccurdy mentioned this pull request Dec 24, 2021
Merged
@donmccurdy donmccurdy force-pushed the remove-color-gamma-methods branch from 0166c88 to 8d91f54 Compare December 24, 2021 05:11
@mrdoob mrdoob added this to the r136 milestone Dec 24, 2021
@mrdoob mrdoob merged commit 9f56628 into mrdoob:dev Dec 24, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 24, 2021

Thanks!

@donmccurdy donmccurdy deleted the remove-color-gamma-methods branch December 24, 2021 11:08
@WestLangley
Copy link
Collaborator

WestLangley commented Dec 24, 2021 •
edited
Loading

Add these methods to Legacy.js?

@mrdoob
Copy link
Owner

mrdoob commented Dec 24, 2021 •
edited
Loading

I suspect not many people used these though?

@joshuaellis joshuaellis mentioned this pull request Jan 3, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r136
Development

Successfully merging this pull request may close these issues.
4 participants
@donmccurdy @mrdoob @WestLangley @Mugen87