Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDrawLoader: Initialize parseScope.groupObject even when !LDRAW_ORG is not specified #23076

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #22957

Description

#22957 enabled LDrawLoader to load the "Scorpion Pyramid" model correctly when "separateObjects" was set to false however when that setting is toggled to "true" an error is thrown because the pyramid mode does not always specify the !LDRAW_ORG command meaning the groupObject is not always created for part. This PR fixes the loader so the group object is always created.

cc @yomboprime

@mrdoob mrdoob added this to the r136 milestone Dec 23, 2021
@mrdoob mrdoob merged commit 5c18248 into mrdoob:dev Dec 23, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 23, 2021

Thanks!

@gkjohnson gkjohnson deleted the separate-object-fix branch December 23, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants