Docs: Refactor link generation to allow more natural mouse interaction. #23071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Dec 28, 2021
Mugen87
changed the title
|
Is there anything I need to change on this PR?? |
|
I come from this issue that was marked as duplicate of this one, which is linked to this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Fixed #13900
Description
This PR makes it possible to open the documentation in another tab by using modifier keys like shift, ctrl, alt, and by middle mouse button. This works because only the first mouse button and no modifier keys update only the hash fragment of the URL. The others use the standard behavior of the hyperlink element.
I've also taken special notice to not break the behavior of accessing the documentation with the file protocol
Here is the new documentation