Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TransformControls] Don't attempt to capture pointer if pointerlock is active #23057

Merged
merged 3 commits into from
Dec 21, 2021

Conversation

jbaicoianu
Copy link
Contributor

Attempting to interact with TransformControls when pointerlock is already active in your app throws the following error:

Uncaught DOMException: Failed to execute 'setPointerCapture' on 'Element': InvalidStateError at TransformControls.onPointerDown

This patch skips the attempt to call this.domElement.setPointerCapture( event.pointerId ) if pointerlock is already active

@mrdoob
Copy link
Owner

mrdoob commented Dec 21, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants