Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Updated signals.min.js #23044

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Editor: Updated signals.min.js #23044

merged 1 commit into from
Jan 3, 2022

Conversation

linbingquan
Copy link
Contributor

Related issue: #---

Description

  1. Updated signals.min.js lib v1.0.0 version.
  2. Improved signals for Editor.js.

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 18, 2021

https://raw.githack.com/linbingquan/three.js/dev-signals/editor/index.html

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 28, 2021

Tested some workflows and it seems everything works as expected.

@Mugen87 Mugen87 added this to the r137 milestone Dec 28, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 30, 2021 •
edited
Loading

Their documentation still has this...

var Signal = signals.Signal;

🤔

@linbingquan
Copy link
Contributor Author

Their documentation still has this...

var Signal = signals.Signal;

Should I not modify editor.js.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 2, 2022 •
edited
Loading

Yes, please undo the change to Editor.js so the usage of signals corresponds to the documentation.

@linbingquan linbingquan changed the title Editor: Updated signals.min.js and improved Editor.js Editor: Updated signals.min.js Jan 2, 2022
@mrdoob mrdoob merged commit d045605 into mrdoob:dev Jan 3, 2022
@mrdoob
Copy link
Owner

mrdoob commented Jan 3, 2022

Thanks!

@linbingquan linbingquan deleted the dev-signals branch August 19, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r137
Development

Successfully merging this pull request may close these issues.
3 participants
@linbingquan @Mugen87 @mrdoob