Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathNode: Fix typo in STEP #23042

Merged
merged 1 commit into from
Dec 19, 2021
Merged

MathNode: Fix typo in STEP #23042

merged 1 commit into from
Dec 19, 2021

Conversation

wmcmurray
Copy link
Contributor

While creating a MathNode like this:

const nodeC = new Nodes.MathNode(Nodes.MathNode.STEP, nodeA, nodeB);

The resulting GLSL code was something like this:

nodeVar2 = step( nodeVar1, nodeVar1 );

when it should instead be:

nodeVar2 = step( nodeVar0, nodeVar1 );

cc @sunag

Copy link
Collaborator

@sunag sunag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sunag sunag changed the title Fix typo in STEP MathNode MathNode: Fix typo in STEP Dec 19, 2021
@Mugen87 Mugen87 added this to the r136 milestone Dec 19, 2021
@Mugen87 Mugen87 merged commit 9dee529 into mrdoob:dev Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants