Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArcballControls: Remove keydown event listener. #23028

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 15, 2021

Related issue: Fixed #23023

Description

Removes the keydown event listener of ArcballControls and implements it on app level.

This approach makes less assumptions on how the app wants to save/restore the state of the controls.

@mrdoob mrdoob added this to the r136 milestone Dec 15, 2021
@mrdoob mrdoob merged commit 007b2a0 into mrdoob:dev Dec 15, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 15, 2021

Thanks!

@casparolesen
Copy link

When is this expected to be released to npm? 😊

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 16, 2021

When r136 will be released this month. The planned date is 12.22.2021.

@casparolesen
Copy link

When r136 will be released this month. The planned date is 12.22.2021.

Cool, thanks!

gero3 pushed a commit to gero3/three.js that referenced this pull request Dec 16, 2021
@joshuaellis joshuaellis mentioned this pull request Dec 19, 2021
9 tasks
@mgroeneweg
Copy link

I noticed ArcBallControls still attempts to remove the keydown event listener at line 2078. Not sure whether that is a problem though

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 23, 2021

Good catch! Fixed 4ea1a19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArcballControls steals ctrl-C/V keyboard shortcuts
4 participants