Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual: Fix exponential backtracking in lessons-helper.js. #23026

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

gero3
Copy link
Contributor

@gero3 gero3 commented Dec 14, 2021

Description

Fix the exponential backtracking regex in lessons-helper.js. This resolves the following lgtm error.
This is fixed by making sure there are no 2 quantifiers on top of each other meaning the + quantifier and the *? quantifier in the regex.

@Mugen87 Mugen87 added this to the r136 milestone Dec 15, 2021
@Mugen87 Mugen87 changed the title fix exponential backtracking in lessons-helper.js Manual: Fix exponential backtracking in lessons-helper.js. Dec 15, 2021
@Mugen87 Mugen87 merged commit cf5e5f3 into mrdoob:dev Dec 15, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 15, 2021

Thanks!

gero3 added a commit to gero3/three.js that referenced this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants