Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebGLShaderCache. #23022

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Add WebGLShaderCache. #23022

merged 1 commit into from
Dec 15, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 14, 2021

Related issue: #22530

Description

Improves the performance of getProgramCacheKey() by assigning IDs to custom shaders and use them as a replacement for the existing hash strings.

Alternative implementation to #22978.

Performance tests in #22978 demonstrated that both PRs noticeably improve the performance in scenes with many custom materials.

@mrdoob mrdoob added this to the r136 milestone Dec 15, 2021
@mrdoob mrdoob merged commit 9b86245 into mrdoob:dev Dec 15, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 15, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants