Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Improve Texture page. #22986

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Docs: Improve Texture page. #22986

merged 1 commit into from
Dec 9, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 9, 2021 •
edited
Loading

Related issue: #22718, closes #22882

Description

Highlights that clone() does not raise the version counter of a texture.

@Mugen87 Mugen87 merged commit a4e6029 into mrdoob:dev Dec 9, 2021
@Mugen87 Mugen87 added this to the r136 milestone Dec 9, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 9, 2021

Hmm, I think we should probably copy the version when we clone.
But I maybe I am missing a side effect?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 10, 2021

But I maybe I am missing a side effect?

I think there is a use case that breaks when the version is copied: #22718 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r136
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob