Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectionBox: Honor transformation of InstancedMesh. #22962

Merged
merged 1 commit into from
Dec 8, 2021
Merged

SelectionBox: Honor transformation of InstancedMesh. #22962

merged 1 commit into from
Dec 8, 2021

Conversation

chiguaboy
Copy link
Contributor

Related issue: #22399

Description

point should apply matrixworld in InstancedMesh when using frustum.containsPoint

Mugen87
Mugen87 approved these changes Dec 6, 2021
View reviewed changes
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Seems the support for InstancedMesh was tested without transforming the instanced mesh object itself.

@Mugen87 Mugen87 changed the title fix: point applys matrixworld in InstancedMesh when using selectionbox SelectionBox: Honor transformation of InstancedMesh. Dec 8, 2021
@Mugen87 Mugen87 added this to the r136 milestone Dec 8, 2021
@Mugen87 Mugen87 merged commit 8abf54b into mrdoob:dev Dec 8, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 8, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r136
Development

Successfully merging this pull request may close these issues.
3 participants
@chiguaboy @mrdoob @Mugen87