-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual: Fix fullscreen mode. #22953
Manual: Fix fullscreen mode. #22953
Conversation
Unrelated to this PR: It seems it's not possible to preview manual changes on githack. The styles break as soon as you open a page. https://raw.githack.com/mrdoob/three.js/dev/manual/index.html |
Tested the change locally and the styles seems to be fixed! However, it seems the canvas vertically overflows now. Meaning objects like the cube in the first demo of https://threejs.org/manual/#en/textures are not centered anymore when entering fullscreen. |
@Mugen87 width: calc(100% - 300px); instead of right: 0 does fix it, let me try to push... |
try now @Mugen87 |
Looking good now! |
test https://raw.githack.com/ycw/three.js/dev/manual/index.html#en/cameras |
@ycw It would be great if you could file a PR with your fix! |
@Mugen87 i prefer @greggman rewrites the links transformers (into relpath instead of abspath) for all links ( includes those in js files, e.g. three.js/manual/examples/resources/editor.js Line 1436 in a0de39b
|
Thanks! |
Fixed #22890.
@Mugen87 we dont even need mobile media query here since the toolbar with the fullscreen button disappears at widths < 1000px