Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual: Fix fullscreen mode. #22953

Merged
merged 2 commits into from
Dec 4, 2021
Merged

Manual: Fix fullscreen mode. #22953

merged 2 commits into from
Dec 4, 2021

Conversation

makc
Copy link
Contributor

@makc makc commented Dec 3, 2021

Fixed #22890.

@Mugen87 we dont even need mobile media query here since the toolbar with the fullscreen button disappears at widths < 1000px

@Mugen87 Mugen87 changed the title fixes #22890 Manual: Fix fullscreen mode. Dec 3, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 3, 2021

Unrelated to this PR: It seems it's not possible to preview manual changes on githack. The styles break as soon as you open a page.

https://raw.githack.com/mrdoob/three.js/dev/manual/index.html

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 3, 2021

Tested the change locally and the styles seems to be fixed!

However, it seems the canvas vertically overflows now. Meaning objects like the cube in the first demo of https://threejs.org/manual/#en/textures are not centered anymore when entering fullscreen.

@makc
Copy link
Contributor Author

makc commented Dec 3, 2021

@Mugen87 width: calc(100% - 300px); instead of right: 0 does fix it, let me try to push...

@makc
Copy link
Contributor Author

makc commented Dec 3, 2021

try now @Mugen87

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 3, 2021

Looking good now!

@ycw
Copy link
Contributor

ycw commented Dec 3, 2021

Unrelated to this PR: It seems it's not possible to preview manual changes on githack. The styles break as soon as you open a page.

https://raw.githack.com/mrdoob/three.js/dev/manual/index.html

missing <base target='......'> use relpath for each html in https://github.com/mrdoob/three.js/tree/dev/manual/en

test https://raw.githack.com/ycw/three.js/dev/manual/index.html#en/cameras
html https://github.com/ycw/three.js/blob/756b149758fa1feef055a36990468a8c1e119fc7/manual/en/cameras.html#L12

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 4, 2021

@ycw It would be great if you could file a PR with your fix!

@Mugen87 Mugen87 added this to the r136 milestone Dec 4, 2021
@Mugen87 Mugen87 merged commit e358365 into mrdoob:dev Dec 4, 2021
@makc makc deleted the patch-1 branch December 4, 2021 09:44
@ycw
Copy link
Contributor

ycw commented Dec 4, 2021

@ycw It would be great if you could file a PR with your fix!

@Mugen87 i prefer @greggman rewrites the links transformers (into relpath instead of abspath) for all links ( includes those in js files, e.g.

require.config({ paths: { 'vs': '/manual/3rdparty/monaco-editor/min/vs' }});
)

@mrdoob
Copy link
Owner

mrdoob commented Dec 4, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual: Editor is obscured.
4 participants