WebGLTextures: Use gl.texStorage2D() in uploadCubeTexture(). #22951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Fixed #21874.
Description
With this PR
gl.texStorage2D()
is used in bothuploadTexture()
anduploadCubeTexture()
.BTW: I've added a
TODO
comment touploadCubeTexture()
to highlight a subtle issue that should be solved at some point. It's about how mipmaps are defined for uncompressed cube maps which works different compared to all other use cases. It's unrelated togl.texStorage2D()
and more a conceptual thing.