Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLTextures: Use gl.texStorage2D() in uploadCubeTexture(). #22951

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 3, 2021

Related issue: Fixed #21874.

Description

With this PR gl.texStorage2D() is used in both uploadTexture() and uploadCubeTexture().

BTW: I've added a TODO comment to uploadCubeTexture() to highlight a subtle issue that should be solved at some point. It's about how mipmaps are defined for uncompressed cube maps which works different compared to all other use cases. It's unrelated to gl.texStorage2D() and more a conceptual thing.

@Mugen87 Mugen87 marked this pull request as draft December 3, 2021 12:24
@Mugen87 Mugen87 marked this pull request as ready for review December 3, 2021 12:42
@Mugen87 Mugen87 added this to the r136 milestone Dec 3, 2021
@Mugen87 Mugen87 merged commit ae50d5b into mrdoob:dev Dec 3, 2021
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 3, 2021

Updated builds for testing on dev: 30c8def

@mrdoob
Copy link
Owner

mrdoob commented Dec 3, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for texStorage
2 participants