Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLPrograms: Some small cleanups around getProgramCacheKey(). #22945

Merged
merged 2 commits into from
Dec 3, 2021
Merged

WebGLPrograms: Some small cleanups around getProgramCacheKey(). #22945

merged 2 commits into from
Dec 3, 2021

Conversation

gero3
Copy link
Contributor

@gero3 gero3 commented Dec 3, 2021 •
edited
Loading

Description

Some small cleanups around getProgramCacheKey:

  • Remove empty Parameter from list.
  • vertexUvs is also a boolean value.

@gero3 gero3 marked this pull request as ready for review December 3, 2021 01:50
@Mugen87 Mugen87 merged commit 38c7ef5 into mrdoob:dev Dec 3, 2021
@Mugen87 Mugen87 added this to the r136 milestone Dec 3, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 3, 2021

Thanks!

@Mugen87 Mugen87 changed the title Some small cleanups around getProgramCacheKey WebGLPrograms: Some small cleanups around getProgramCacheKey(). Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r136
Development

Successfully merging this pull request may close these issues.
3 participants
@gero3 @mrdoob @Mugen87