Cleanup eslint globals + update deprecated config #22940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Dec 2, 2021
|
Thanks! |
gero3
added a commit
to gero3/three.js
that referenced
this pull request
Dec 3, 2021
mrdoob
pushed a commit
that referenced
this pull request
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up the eslint exceptions in the src folder and adds the required globals to the eslint config. The globals also now are set as read-only. eslint captures than the assignments to 1 of these globals. This also resolves the deprecation of boolean values with globals in an eslint config.
Info about the deprecation of boolean values with global definitions can be found here:https://eslint.org/docs/user-guide/configuring/language-options#specifying-globals