Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unittests to WEBGLExtensions #22939

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Conversation

gero3
Copy link
Contributor

@gero3 gero3 commented Dec 2, 2021

Description

This cleans up the WebglExtensions file and adds unit tests to verify changes to it.
This makes it easier to add aliases to extension names in of webgl extensions.

@@ -12,26 +33,23 @@ function WebGLExtensions( gl ) {

let extension;

switch ( name ) {
if ( aliasses[ name ] === undefined ) {
Copy link
Collaborator

@Mugen87 Mugen87 Dec 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, this feels a bit over-engineered to me. Yes, the previous code was "dumber" but also easier to read. I tend to leave the code as it is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted that change so that there is only the unit test left.

@gero3 gero3 changed the title Add aliases in WEBGLExtensions + Unittests Add Unittests to WEBGLExtensions Dec 2, 2021
@mrdoob mrdoob added this to the r136 milestone Dec 3, 2021
@mrdoob mrdoob merged commit 384d1e9 into mrdoob:dev Dec 3, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 3, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants